From: Johan Herland <johan@herland.net>
Date: Sun, 19 Jun 2011 21:25:00 GMT
Subject: Re: [PATCH 2/6] Factorize shortening of notes refname for display.
Message-ID: <201106192325.00667.johan@herland.net>
In-Reply-To: <1308431208-13353-3-git-send-email-ydirson@free.fr>

On Saturday 18 June 2011, Yann Dirson wrote:
> Signed-off-by: Yann Dirson <ydirson@free.fr>
> ---
>  notes.c |   24 ++++++++++++++++--------
>  notes.h |    7 +++++++
>  2 files changed, 23 insertions(+), 8 deletions(-)
> 
> [...]
> 
>  /*
> + * Return a short name for a notes ref, suitable for display to the user.
> + *
> + * No copy is done, the return value is a pointer into the original string.
> + */
> +const char *notes_ref_shortname(const char *ref);
> +
> +/*

Please include in the documentation what a NULL return means.

Otherwise the patch looks OK.


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net