From: Jeff King <peff@github.com>
Date: Thu, 16 Jun 2011 06:51:46 GMT
Subject: Re: [PATCH 7/7] archive: provide builtin .tar.gz filter
Message-ID: <20110616065146.GA30672@sigill.intra.peff.net>
In-Reply-To: <7v39jai94h.fsf@alter.siamese.dyndns.org>

On Wed, Jun 15, 2011 at 11:27:26PM -0700, Junio C Hamano wrote:

> Jeff King <peff@github.com> writes:
> 
> > This feels a little wrong, as we are changing what the tool outputs all
> > the time just to appease a poorly-written test.
> 
> Now you confused me.  Isn't '-n' to tell the tool *not* to write timestamp
> out, so that we can avoid changing what the tool outputs all the time?

No, I mean that people may _want_ the timestamp in day to day use. Using
"-n" all the time suppresses it. And there is no reason to suppress it,
except that our test does not account for it properly. So your patch is
hurting people who don't want "-n" (i.e., want the timestamp) just to
make our test happy.

-Peff