From: Carlos Martín Nieto Date: Sat, 28 May 2011 17:26:11 GMT Subject: Re: git show and the --quiet option Message-ID: <20110528172611.GB28708@centaur.lab.cmartin.tk> In-Reply-To: <4DE12888.1040506@isy.liu.se> On Sat, May 28, 2011 at 06:53:28PM +0200, Gustaf Hendeby wrote: > Hello everyone, > > I was playing around with "git show" lately and realized it has changed > its behavior regarding the --quiet option, which no longer suppresses > the diff output as it used to. The behavior change happened in > 1c40c36b ("log: convert to parse-options"). Was this intentional? Very much so. > > The commit message talks about the --quiet handling being improved and > the "git show" help doesn't mention a --quiet option. Is the simple > answer that the previous behavior was incorrect? Yes. The long answer is that the log family (and git-format-patch, which is where this started) never actually accepted --quiet, so it would get passed down to the diff machinery. This (for complicated reasons I'm not sure I comletely understand, but that have to do with the internal handling of 'quiet' as 'quick') caused every second commit not to show. As you noticed, the man page never mentions a --quiet option (because, honestly, it doesn't make any sense), so any use of that flag is wrong. Part of what the patch does is make --quiet a no-op to guard against the effect of disappearing commits. How are you using the --quiet option and why would you even need it? Cheers, cmn -- Carlos Martín Nieto | http://cmartin.tk "¿Cómo voy a decir bobadas si soy mudo?" -- CACHAI