From: Jeff King <peff@peff.net>
Date: Thu, 26 May 2011 21:19:52 GMT
Subject: Re: [PATCH 3/3] format-patch: preserve subject newlines with -k
Message-ID: <20110526211952.GA32097@sigill.intra.peff.net>
In-Reply-To: <7vboypw47q.fsf@alter.siamese.dyndns.org>

On Thu, May 26, 2011 at 02:18:33PM -0700, Junio C Hamano wrote:

> > diff --git a/builtin/log.c b/builtin/log.c
> > index d8c6c28..3fdf488 100644
> > --- a/builtin/log.c
> > +++ b/builtin/log.c
> > @@ -768,7 +768,7 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,
> >  	pp_user_info(NULL, CMIT_FMT_EMAIL, &sb, committer, DATE_RFC2822,
> >  		     encoding);
> >  	pp_title_line(CMIT_FMT_EMAIL, &msg, &sb, subject_start, extra_headers,
> > -		      encoding, need_8bit_cte);
> > +		      encoding, need_8bit_cte, 0);
> 
> I do not appreciate a single-bit tweak as separate parameter to a
> function.  Back when pp_title_line() had only "do we need 8-bit cte", it
> was Ok, but now that you are adding another bit, could we make it an
> "unsigned flag"?

Actually, I wonder if we can refactor to just pass the pretty_context to
pp_title_line. Let me see what I can do.

-Peff