From: Jeff King Date: Thu, 26 May 2011 21:17:23 GMT Subject: Re: [PATCH 2/2] builtin/commit.c: set status_format _after_ option parsing Message-ID: <20110526211723.GE31340@sigill.intra.peff.net> In-Reply-To: On Thu, May 26, 2011 at 01:43:21PM -0700, Brandon Casey wrote: > 'git status' should use --porcelain output format when -z is given. > It was not doing so since the _effect_ of using -z, namely that > null_termination would be set, was being checked _before_ option parsing > was performed. > > So, move the check so that it is performed after option parsing. Wow, that's an embarrassing bug. I was about to own up to it, but it actually looks like it is Junio's bug from 173e6c8 (git stat -s: short status output, 2009-08-04). Of course, I _twice_ modified the conditional afterwards and failed to notice that it was doing absolutely nothing. So I'm not sure which one of us deserves the brown paper bag. :) Your fix looks obviously correct. Acked-by: Jeff King -Peff