From: Jonathan Nieder Date: Thu, 26 May 2011 16:39:21 GMT Subject: Re: [PATCH 2/2] Include unistd.h. Message-ID: <20110526163921.GD24931@elie> In-Reply-To: <7vhb8hzcm8.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > --- a/compat/fnmatch/fnmatch.c > +++ b/compat/fnmatch/fnmatch.c > @@ -127,6 +127,10 @@ extern char *getenv (); > extern int errno; > # endif > + > +# ifndef NULL > +# define NULL 0 > +# endif Makes a lot of sense. This fits well with the style of the rest of the file and other projects using glibc fnmatch could reuse the fix even if targeting ancient platforms.