From: Jeff King Date: Thu, 26 May 2011 15:28:56 GMT Subject: Re: [PATCH] remote: allow "-t" with fetch mirrors Message-ID: <20110526152855.GA4120@sigill.intra.peff.net> In-Reply-To: <4DDE7116.4070900@viscovery.net> On Thu, May 26, 2011 at 05:26:14PM +0200, Johannes Sixt wrote: > Am 5/26/2011 17:11, schrieb Jeff King: > > + if (mirror && !(mirror & MIRROR_FETCH) && track.nr) > > + die("specifying branches to track makes no sense with non-fetch mirrors"); > > Don't proliferate no double negation. How about: > > + die("specifying branches to track makes sense only with fetch mirrors"); I can't fail to not disagree with your logic. Junio, can you squash it in? -Peff