From: Jeff King Date: Tue, 24 May 2011 22:49:36 GMT Subject: [PATCH 1/4] config: make environment parsing routines static Message-ID: <20110524224936.GA24527@sigill.intra.peff.net> In-Reply-To: <20110524224903.GA16265@sigill.intra.peff.net> Nobody outside of git_config_from_parameters should need to use the GIT_CONFIG_PARAMETERS parsing functions, so let's make them private. Signed-off-by: Jeff King --- cache.h | 2 -- config.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cache.h b/cache.h index 28a921d..69e09a1 100644 --- a/cache.h +++ b/cache.h @@ -1037,8 +1037,6 @@ typedef int (*config_fn_t)(const char *, const char *, void *); extern int git_default_config(const char *, const char *, void *); extern int git_config_from_file(config_fn_t fn, const char *, void *); extern void git_config_push_parameter(const char *text); -extern int git_config_parse_parameter(const char *text); -extern int git_config_parse_environment(void); extern int git_config_from_parameters(config_fn_t fn, void *data); extern int git_config(config_fn_t fn, void *); extern int git_config_early(config_fn_t fn, void *, const char *repo_config); diff --git a/config.c b/config.c index 9d36848..46aeb9c 100644 --- a/config.c +++ b/config.c @@ -47,7 +47,7 @@ void git_config_push_parameter(const char *text) strbuf_release(&env); } -int git_config_parse_parameter(const char *text) +static int git_config_parse_parameter(const char *text) { struct config_item *ct; struct strbuf tmp = STRBUF_INIT; @@ -74,7 +74,7 @@ int git_config_parse_parameter(const char *text) return 0; } -int git_config_parse_environment(void) { +static int git_config_parse_environment(void) { const char *env = getenv(CONFIG_DATA_ENVIRONMENT); char *envw; const char **argv = NULL; -- 1.7.4.5.7.g2e01