From: Jeff King <peff@peff.net>
Date: Mon, 23 May 2011 18:11:47 GMT
Subject: Re: combined diff does not detect binary files and ignores -diff attribute
Message-ID: <20110523181147.GA26035@sigill.intra.peff.net>
In-Reply-To: <BANLkTinu3AbTmtswn6DLQKAWdLL=gBvAqA@mail.gmail.com>

On Mon, May 23, 2011 at 11:17:14AM -0400, Jay Soffian wrote:

> > We know, but we somehow got stuck, see:
> >
> > http://permalink.gmane.org/gmane.comp.version-control.git/171613
> >
> > I don't have the time to follow up on this currently, it got out of
> > proportion.
> 
> Drat, seems like the perfect being the enemy of the good there. I
> wonder if Junio's patch in that thread isn't good enough for now.

I'll have a patch series in a few minutes that at least handles the
binary case. I'll see how painful the textconv bit is on top of that.

-Peff