From: Christian Couder <chriscool@tuxfamily.org>
Date: Sat, 21 May 2011 03:47:23 GMT
Subject: Re: Better error-handling around revert
Message-ID: <201105210547.24831.chriscool@tuxfamily.org>
In-Reply-To: <20110520072846.GB6755@domU-12-31-39-06-A8-0A.compute-1.internal>

Hi,

On Friday 20 May 2011 09:28:47 Ramkumar Ramachandra wrote:
> Hi,
> 
> Ugh, sorry about the whitespace breakage. Here's a fresh diff:

It looks like there is still whitespace breakage, because code is not indented 
anymore.

>     write_cherry_pick_head and write_message used to die when an operation
>     such as write_in_full failed.  Instead, clean up correctly, and return
>     an error to be handled by the caller.

Otherwise it looks good to me.

Thanks,
Christian.