From: Jeff King Date: Wed, 18 May 2011 08:21:30 GMT Subject: Re: [PATCH 1/2] config: define and document exit codes Message-ID: <20110518082130.GG27482@sigill.intra.peff.net> In-Reply-To: <6301052eb455e9088e50f78760e6ca1b9499564a.1305646709.git.git@drmicha.warpmail.net> On Tue, May 17, 2011 at 05:38:52PM +0200, Michael J Gruber wrote: > The return codes of git_config_set() and friends are magic numbers right > in the source. #define them in cache.h where the functions are declared, > and use the constants in the source. > > Also, mention the resulting exit codes of "git config" in its man page > (and complete the list). This version (and the accompanying 2/2) both look sane to me. Thanks for taking time to clean up. -Peff