From: Kacper Kornet <draenog@pld-linux.org>
Date: Thu, 05 May 2011 18:53:56 GMT
Subject: Re: [PATCH] Fix test t3701-add-interactive.sh
Message-ID: <20110505185355.GG31229@camk.edu.pl>
In-Reply-To: <7vzkn16m0q.fsf@alter.siamese.dyndns.org>

On Thu, May 05, 2011 at 11:27:17AM -0700, Junio C Hamano wrote:
> Kacper Kornet <draenog@pld-linux.org> writes:

> > One of the tests used to fail due to EOF not in the first column and not
> > continued &&.

> > Signed-off-by: Kacper Kornet <draenog@pld-linux.org>
> > ---
> >  t/t3701-add-interactive.sh |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)

> > diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
> > index d6327e7..018f5d9 100755
> > --- a/t/t3701-add-interactive.sh
> > +++ b/t/t3701-add-interactive.sh
> > @@ -83,9 +83,9 @@ EOF

> >  test_expect_success PERL 'setup fake editor' '
> >  	cat >fake_editor.sh <<EOF
> > -	EOF
> > +EOF
> >  	chmod a+x fake_editor.sh &&
> > -	test_set_editor "$(pwd)/fake_editor.sh" &&
> > +	test_set_editor "$(pwd)/fake_editor.sh"
> >  '

> Very curious. I never saw the breakage.  We are getting:

It is probably we are using a different shell as /bin/sh.

> Well spotted.  Thanks.

By the way. The credit shoud probably go to qboosh@pld-linux.org. I have
just rediscovered it in my private build.
-- 
  Kacper Kornet