From: Kacper Kornet <kornet@camk.edu.pl>
Date: Thu, 05 May 2011 15:00:36 GMT
Subject: Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir
Message-ID: <20110505150036.GB31229@camk.edu.pl>
In-Reply-To: <4DC2B814.5070507@viscovery.net>

On Thu, May 05, 2011 at 04:45:40PM +0200, Johannes Sixt wrote:
> A:

> > 1. ./configure --prefix=dir1  and dir1 != /usr

> >     git_etcdir = etc

> > 2. ./configure --prefix=/usr

> >     git_etcdir = /etc

> > 3. ./configure --prefix=dir1 --syscondir=dir2 (here dir2 has to be
> > an
> > absolute path)

> >     git_etcdir =  dir2

> Why do you have the restriction that --sysconfdir must be absolute? Is
> it
> imposed by autotools?

Yes, configure does not accept relative pathnames.

>   4. ./configure --sysconfdir=dir2

>      git_etcdir =  dir2

> B:

> > 1. make prefix=dir1 and dir1 != /usr

> >     git_etcdir = etc

> > 2. make prefix=/usr

> >     git_etcdir = /etc

> > 3. make prefix=dir1 sysconfdir=dir2 (here dir2 can be an absolute or
> > a relative path)

> >     git_etcdir = dir2

>   4. make sysconfdir=dir2

>       git_etcdir = dir2

> C:
> in config.mak write none, one, or both of

>   prefix=dir1
>   sysconfdir=dir2

> with the same 4 case distinctions and corresponding desired results as
> in B.

> Looks fine and simple to implement, except that I don't see that you
> have
> to introduce git_etcdir; can't you just stick with the name
> "sysconfdir"?

I can do it, if Junio is ok with it.

Should the patch be based on main or on the previous patch that was
merged to next?

-- 
  Kacper Kornet