From: Michal Kiedrowicz <michal.kiedrowicz@gmail.com>
Date: Thu, 05 May 2011 07:43:20 GMT
Subject: Re: [PATCH V2 4/5] git-grep: Learn PCRE
Message-ID: <20110505094320.5d64234f@mkiedrowicz>
In-Reply-To: <4DC24371.7060906@viscovery.net>

On 05.05.2011 08:28:01 +0200 Johannes Sixt <j.sixt@viscovery.net> wrote:

> Am 5/5/2011 0:00, schrieb Michał Kiedrowicz:
> > +# Define NO_LIBPCRE if you do not have libpcre installed.
> 
> This makes libpcre a requirement with an opt-out. But I can imagine
> that there are many platforms where libpcre is not installed. We
> would have to add NO_LIBPRCE=1 to many platform configuration
> sections. But how can this setting be countermanded if someone does
> install libpcre on such a platform?
> 
> Wouldn't it be better to make this an opt-in (USE_LIBPCRE)?
> 
> -- Hannes

Yes, Junio already wrote that too. I'll change that.

Thanks!