From: Jeff King <peff@peff.net>
Date: Thu, 05 May 2011 05:46:11 GMT
Subject: Re: t5541: Bad file descriptor
Message-ID: <20110505054611.GA29033@sigill.intra.peff.net>
In-Reply-To: <7voc3hbtgu.fsf@alter.siamese.dyndns.org>

On Wed, May 04, 2011 at 10:35:13PM -0700, Junio C Hamano wrote:

> Brian Gernhardt <brian@gernhardtsoftware.com> writes:
> 
> > I haven't had a lot of time to track down it down until today, but I've
> > been getting failures in t5541-http-push-.sh.  Several tests fail with
> > the error "fatal: write error: Bad file descriptor".
> 
> A wild guess.
> 
> Does it help if you cherry-picked 1e41827 (http: clear POSTFIELDS when
> initializing a slot, 2011-04-26) on top of the faulty commit?

I think that 09c9957 (send-pack: avoid deadlock when pack-object dies
early, 2011-04-25) is totally broken.

Looking back at my tests, I only tested the case where pack-objects
fails. And it seems we totally broke the case where the push is supposed
to succeed.

Still investigating...

-Peff