From: Kacper Kornet <kornet@camk.edu.pl>
Date: Wed, 04 May 2011 13:58:27 GMT
Subject: Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir
Message-ID: <20110504135827.GC18585@camk.edu.pl>
In-Reply-To: <4DC0E99E.6090402@viscovery.net>

On Wed, May 04, 2011 at 07:52:30AM +0200, Johannes Sixt wrote:
> Looking closer, the patch introduces git_etcdir for no good reason,
> IIUC.
> It should just re-use sysconfdir (the meaning of this variable is to
> point
> to the etc directory).

And the first version of my patch did it. However Junio has written:

> But this part in the Makefile outside the context of the patch bothers
> me.  It seems to imply that sysconfdir is _not_ that variable you want
> to
> define later.
>
>    # Among the variables below, these:
>    #   gitexecdir
>    #   template_dir
>    #   mandir
>    #   infodir
>    #   htmldir
>    #   ETC_GITCONFIG (but not sysconfdir)
>    #   ETC_GITATTRIBUTES
>    # can be specified as a relative path some/where/else;
>
> So I have a suspicion that your patch as is will break when prefix is
> set
> to something other than /usr directory.  I don't think anybody in-tree
> currently uses sysconfdir, but that does not mean nobody will ever do.

>From that I understood that he prefers sysconfdir to be always an
absolute path.
-- 
  Kacper Kornet