From: Eric Wong Date: Mon, 25 Apr 2011 21:06:23 GMT Subject: Re: [PATCH 0/2] Documentation fixes for git-svn.txt Message-ID: <20110425210623.GB13953@dcvr.yhbt.net> In-Reply-To: <1303491819-9850-1-git-send-email-valentin.haenel@gmx.de> Valentin Haenel wrote: > My remaining question regarding the second option, '--add-author-from', > is about the subcommands which it is applicable to. The current > documentation states 'commit' and 'dcommit'. My feeling is that 'commit' > is a typo, since 'git svn' does not have a 'commit' subcommand. I had a > look at the code, and while I am not familiar with perl, it seems to me > that the three subcommands that use the option are 'commit-diff', > 'set-tree' and 'dcommit'. But this is non-trivial -- feedback is > appreciated. Yes, commit-diff, set-tree, and dcommit all use --add-author-from. I don't have time to build the docs and test formatting, but your changes all look reasonable, consider them: Acked-by: Eric Wong Thanks! -- Eric Wong