From: Jeff King <peff@peff.net>
Date: Fri, 01 Apr 2011 01:35:20 GMT
Subject: Re: [PATCH 1/4] teach wait_or_whine a "quiet" mode
Message-ID: <20110401013519.GB21036@sigill.intra.peff.net>
In-Reply-To: <201103312256.39317.j6t@kdbg.org>

On Thu, Mar 31, 2011 at 10:56:39PM +0200, Johannes Sixt wrote:

> On Donnerstag, 31. März 2011, Jeff King wrote:
> > The wait_or_whine function will complain to stderr in a few
> > cases:
> >
> >   1. We fail to actually waitpid() correctly.
> >
> >   2. The child died of a signal.
> >
> >   3. The child returned exit code 127, indicating a missing
> >      command to exec after forking.
> >
> > We already have a silent_exec_failure flag to silence (3).
> > Let's convert that into a "quiet" flag to also silence (2).
> 
> I'm rather negative on controlling these two error reports with the same flag 
> because...

Fair enough. We can add an extra flag, then, or just drop both patches
entirely. They are just trying to save the "child process killed"
message when we abort a separate-process async.

-Peff