From: Jeff King Date: Tue, 29 Mar 2011 20:56:04 GMT Subject: [PATCH 2/6] revision.c: refactor notes ref expansion Message-ID: <20110329205604.GB23466@sigill.intra.peff.net> In-Reply-To: <20110329205307.GA30959@sigill.intra.peff.net> No need to do it ourselves when there is a library function. Signed-off-by: Jeff King --- revision.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/revision.c b/revision.c index 0f38364..5826e5d 100644 --- a/revision.c +++ b/revision.c @@ -1374,13 +1374,8 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg revs->show_notes_given = 1; if (!revs->notes_opt.extra_notes_refs) revs->notes_opt.extra_notes_refs = xcalloc(1, sizeof(struct string_list)); - if (!prefixcmp(arg+13, "refs/")) - /* happy */; - else if (!prefixcmp(arg+13, "notes/")) - strbuf_addstr(&buf, "refs/"); - else - strbuf_addstr(&buf, "refs/notes/"); strbuf_addstr(&buf, arg+13); + expand_notes_ref(&buf); string_list_append(revs->notes_opt.extra_notes_refs, strbuf_detach(&buf, NULL)); } else if (!strcmp(arg, "--no-notes")) { -- 1.7.4.2.7.g9407