From: Jonathan Nieder Date: Tue, 29 Mar 2011 20:02:48 GMT Subject: Re: [PATCH] Portability: returning void Message-ID: <20110329200230.GA377@elie> In-Reply-To: <71372d7d-dd08-4945-a8bc-c7b981c09fb2-mfwitten@gmail.com> Hi, Michael Witten wrote: > Currently, building git with: > > CFLAGS="-std=c99 -pedantic -Wall -Werror -g -02" > > causes gcc 4.5.2 to fail with: > > vcs-svn/svndump.c:217:3: error: ISO C forbids 'return' with > expression, in function > returning void [...] > Signed-off-by: Michael Witten Thanks, looks sensible (and thanks to Junio for a pointer). Applied to git://repo.or.cz/git/jrn.git svn-fe Next step is to figure out the longstanding mysterious bash + prove hang in t0081. Jonathan Nieder (2): vcs-svn: add missing cast to printf argument tests: make sure input to sed is newline terminated Michael Witten (1): vcs-svn: a void function shouldn't try to return something t/t9010-svn-fe.sh | 8 ++++++-- vcs-svn/fast_export.c | 3 ++- vcs-svn/svndump.c | 3 ++- 3 files changed, 10 insertions(+), 4 deletions(-)