From: Jonathan Nieder Date: Sun, 27 Mar 2011 22:17:53 GMT Subject: [PATCH] squash! tests: fix overeager scrubbing of environment variables Message-ID: <20110327221753.GB27445@elie> In-Reply-To: <20110327213756.GD25927@elie> (+cc: Jeff and Ævar for perl advice) Jonathan Nieder wrote: > Jens Lehmann wrote: >> - GIT_SKIP_TESTS >> - GIT_TEST* >> - GIT_PROVE_OPTS >> >> Let's fix that by adding them to the exception list. >> >> Signed-off-by: Jens Lehmann > > Acked-by: Jonathan Nieder > > It misses a few, though: > > - GIT_REMOTE_SVN_TEST_BIG_FILES > - GIT_NOTES_TIMING_TESTS > - GIT_PATCHID_TIMING_TESTS > - GIT_VALGRIND_OPTIONS How about something like this on top? Would it still be safe on platforms with ancient perl? Signed-off-by: Jonathan Nieder --- t/test-lib.sh | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 4a8c443..d28e647 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -46,7 +46,15 @@ unset VISUAL unset EMAIL unset $(perl -e ' my @env = keys %ENV; - my @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP|SKIP_TESTS|TEST|PROVE_OPTS)/, @env); + my @vars = grep(/^GIT_/ && !m{^GIT_( + TRACE | + DEBUG | + USE_LOOKUP | + TEST | + .*_TEST | + PROVE | + VALGRIND + )}x, @env); print join("\n", @vars); ') GIT_AUTHOR_EMAIL=author@example.com -- 1.7.4.2