From: Alex Riesen Date: Sat, 26 Mar 2011 18:46:34 GMT Subject: [PATCH] HOME must be set before calling git-init when creating test repositories Message-ID: <20110326184634.GB13496@blimp.localdomain> In-Reply-To: Otherwise the created test repositories will be affected by users ~/.gitconfig. For example, setting core.logAllrefupdates in users config will make all calls to "git config --unset core.logAllrefupdates" fail which will break the first test which uses the statement and expects it to succeed. Signed-off-by: Alex Riesen --- Alex Riesen, Sat, Mar 26, 2011 19:42:14 +0100: > On Sat, Mar 26, 2011 at 19:31, Jeff King wrote: > > > > So you can simplify this to just: > > > > HOME=$TRASH_DIRECTORY > > Aah... I should have actually looked at the "case" which > sets TRASH_DIRECTORY! > > Will resend in a moment. Here. t/test-lib.sh | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 7cc9a52..7965b74 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -984,14 +984,14 @@ rm -fr "$test" || { exit 1 } +HOME="$TRASH_DIRECTORY" +export HOME + test_create_repo "$test" # Use -P to resolve symlinks in our working directory so that the cwd # in subprocesses like git equals our $PWD (for pathname comparisons). cd -P "$test" || exit 1 -HOME=$(pwd) -export HOME - this_test=${0##*/} this_test=${this_test%%-*} for skp in $GIT_SKIP_TESTS -- 1.7.4.1.471.gab01