From: Thomas Rast <trast@student.ethz.ch>
Date: Thu, 24 Mar 2011 20:46:02 GMT
Subject: Re: [PATCH] Test failure when spaces in git root
Message-ID: <201103242146.02728.trast@student.ethz.ch>
In-Reply-To: <1300925506-20378-1-git-send-email-cmskog@gmail.com>

Carl Michael Skog wrote:
> Some of the svn related tests would break when the git root path had
> spaces in it.
[...]
> -quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/')"
> +quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/g')"

If you're already fixing this, shouldn't it be

  $(echo "$svnrepo" | ...)

to stop the expansion process from converting arbitrary series of
whitespace into a single space?

However, any other (than space) character that needs %-quoting would
probably also break the test.  Maybe some more complicated mangling
would be in order.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch