From: Jonathan Nieder Date: Wed, 23 Mar 2011 01:26:54 GMT Subject: [PATCH 0/2] Re: [PATCH 2/2] Actually use retval Message-ID: <20110323012654.GA10621@elie> In-Reply-To: <7v7hbrkovz.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > The likely fix would be to remove assignment to retval instead. Like this, maybe? Jonathan Nieder (2): tree-diff: make diff_tree() return void tree-diff: make diff_tree_sha1() return void diff.h | 4 ++-- revision.c | 9 +++------ tree-diff.c | 17 ++++++----------- 3 files changed, 11 insertions(+), 19 deletions(-)