From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sat, 19 Mar 2011 09:10:03 GMT
Subject: Re: [PATCH 9/9] vcs-svn: use strchr to find RFC822 delimiter
Message-ID: <20110319091003.GE6706@elie>
In-Reply-To: <1300518231-20008-10-git-send-email-david.barr@cordelta.com>

David Barr wrote:

> --- a/vcs-svn/svndump.c
> +++ b/vcs-svn/svndump.c
> @@ -296,10 +296,12 @@ void svndump_read(const char *url)
>  
>  	reset_dump_ctx(url);
>  	while ((t = buffer_read_line(&input))) {
> -		val = strstr(t, ": ");
> +		val = strchr(t, ':');
>  		if (!val)
>  			continue;
>  		*val++ = '\0';
> +		if (*val != ' ')
> +			continue;

This one and the three preceding it (removing sublibraries)
make sense.  Thanks for a pleasant read.

Good night,
Jonathan