From: Jonathan Nieder Date: Sat, 19 Mar 2011 08:01:29 GMT Subject: Re: [PATCH 2/9] vcs-svn: avoid using ls command twice Message-ID: <20110319080129.GA6706@elie> In-Reply-To: <1300518231-20008-3-git-send-email-david.barr@cordelta.com> David Barr wrote: > 3 files changed, 6 insertions(+), 24 deletions(-) :) > --- a/vcs-svn/repo_tree.c > +++ b/vcs-svn/repo_tree.c > @@ -8,39 +8,23 @@ > #include "repo_tree.h" > #include "fast_export.h" > > -const char *repo_read_path(const char *path) > +const char *repo_read_path(const char *path, uint32_t *mode_out) Obviously good, both because it means we can use one round-trip to get the same information that previously took two and because the API just makes more sense. Thanks.