From: Jeff King Date: Mon, 07 Mar 2011 15:47:12 GMT Subject: Re: [PATCH 1/2] documentation fix: git log -p does not imply -c. Message-ID: <20110307154712.GA11934@sigill.intra.peff.net> In-Reply-To: <7vbp1n4vhv.fsf@alter.siamese.dyndns.org> On Sun, Mar 06, 2011 at 04:36:28PM -0800, Junio C Hamano wrote: > Adam Monsen writes: > > > Relates to the thread with subject "frustrated forensics: hard to find > > diff that undid a fix" on the git mailing list. > > > > http://thread.gmane.org/gmane.comp.version-control.git/168481 > > > > I don't wish for anyone to repeat my bungled forensics episode. > > But this patch is wrong, isn't it? > > The --cc format _is_ the default, not -c format. Hmm. "git show" seems to show --cc, but "git log -p" does not show anything. Try: $ git show 1538f21 $ git log -p -1 1538f21 So the current doc seems to be wrong. Should we be fixing the code and not the doc? -Peff