From: Jeff King <peff@peff.net>
Date: Tue, 01 Mar 2011 22:04:29 GMT
Subject: Re: [PATCH v2 18/31] rebase: extract merge code to new source file
Message-ID: <20110301220428.GE23945@sigill.intra.peff.net>
In-Reply-To: <m3sjvb7tg4.fsf@localhost.localdomain>

On Fri, Feb 25, 2011 at 12:27:03PM -0800, Jakub Narebski wrote:

> > > Yes, sourced scripts should not have an executable bit. See 46bac90 for
> > > rationale.
> > 
> > And I should have mentioned: they should go in SCRIPT_LIB in the
> > Makefile, not SCRIPT_SH.
> 
> Shouldn't this information be in Documentation/CodingGuidelines, and
> perhaps also (checking if one doesn't accidentally change executable
> bit on sourced scripts) in Documentation/SubmittingPatches?

I think it might make more sense as comments in the Makefile, which is
not very well commented for people tweaking non-config bits. Patches
welcome.

-Peff