From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 24 Feb 2011 21:08:36 GMT
Subject: Re: [PATCH 3/8] trace: add trace_vprintf
Message-ID: <20110224210836.GE17412@elie>
In-Reply-To: <20110224142814.GC15477@sigill.intra.peff.net>

Jeff King wrote:

> --- a/cache.h
> +++ b/cache.h
> @@ -1067,6 +1067,7 @@ extern void alloc_report(void);
>  /* trace.c */
>  __attribute__((format (printf, 1, 2)))
>  extern void trace_printf(const char *format, ...);
> +extern void trace_vprintf(const char *format, va_list ap);

Micronit.

Though now that I think of it, the format(printf, n, 0) attribute
doesn't seem to be used anywhere in git currently.  Is it unportable?
---
diff --git a/cache.h b/cache.h
index 08b23b2..288d4d0 100644
--- a/cache.h
+++ b/cache.h
@@ -1067,6 +1067,7 @@ extern void alloc_report(void);
 /* trace.c */
 __attribute__((format (printf, 1, 2)))
 extern void trace_printf(const char *format, ...);
+__attribute__((format (printf, 1, 0)))
 extern void trace_vprintf(const char *format, va_list ap);
 __attribute__((format (printf, 2, 3)))
 extern void trace_argv_printf(const char **argv, const char *format, ...);