From: Jonathan Nieder Date: Mon, 21 Feb 2011 12:58:10 GMT Subject: Re: [PATCH 02/15] tests: add GETTEXT_POISON to simulate unfriendly translator Message-ID: <20110221125810.GA18427@elie> In-Reply-To: Hi Ævar, Ævar Arnfjörð Bjarmason wrote: > Why did you change this from "# GETTEXT POISON #" to "Malkovich"? I forgot to mention that change in the cover letter --- thanks for a reminder. > Do those tests still pass with this new string, and is there any > reason to change this? Yes, all the tests in this series still pass (on this machine, at least). Which is why I changed it --- it is a lot easier to explain having the '#' at the beginning and end of a magic string as part of a patch that would break tests without that change. Of course the specific string is arbitrary. All caps sounds fine to me, too. Hope that helps, Jonathan