From: Jonathan Nieder Date: Sun, 20 Feb 2011 02:10:42 GMT Subject: Re: [PATCH 03/72] t/test-lib.sh: add always-set NO_GETTEXT_POISON prerequisite Message-ID: <20110220021031.GB17305@elie> In-Reply-To: <1298143495-3681-4-git-send-email-avarab@gmail.com> Hi Ævar, Ævar Arnfjörð Bjarmason wrote: > Add a new test prerequisite called NO_GETTEXT_POISON to t/test-lib.sh > that's always set for now. Suppose I am writing a new family of tests. Which of them will need the NO_GETTEXT_POISON prerequisite? The name doesn't make it easy to guess. If later the testsuite learns to take a --lang= option to test that git works correctly in my native language, I'd think this same prerequisite would be relevant for that, too. So maybe: Signed-off-by: Jonathan Nieder --- t/test-lib.sh | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index ffcfa2e..32004c1 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1079,10 +1079,8 @@ esac test -z "$NO_PERL" && test_set_prereq PERL test -z "$NO_PYTHON" && test_set_prereq PYTHON -# Always set the NO_GETTEXT_POISON prerequisite while we don't have a -# real gettext implementation in Git. This will be replaced by -# something that varies in a future patch series. -test_set_prereq NO_GETTEXT_POISON +# We can rely on output using the C locale. +test_set_prereq ENGLISH # test whether the filesystem supports symbolic links ln -s x y 2>/dev/null && test -h y 2>/dev/null && test_set_prereq SYMLINKS -- 1.7.4.1