From: Jakub Narebski <jnareb@gmail.com>
Date: Sat, 19 Feb 2011 16:02:29 GMT
Subject: Re: [PATCH v2 2/3] gitweb/gitweb.perl: remove use of qw(...) as parentheses
Message-ID: <201102191702.29648.jnareb@gmail.com>
In-Reply-To: <201102191654.41601.jnareb@gmail.com>

Jakub Narebski wrote:
> On Sat, 19 Feb 2011, Ævar Arnfjörð Bjarmason wrote:

> [...]
> > --- a/gitweb/gitweb.perl
> > +++ b/gitweb/gitweb.perl
> > @@ -3501,7 +3501,7 @@ sub print_feed_meta {
> >  			$href_params{'-title'} = 'log';
> >  		}
> >  
> > -		foreach my $format qw(RSS Atom) {
> > +		foreach my $format (qw(RSS Atom)) {
> >  			my $type = lc($format);
> >  			my %link_attr = (
> >  				'-rel' => 'alternate',

Ah, sorry, if Perl reqyures to use 'foreach (@array)', then
of course one should use 'forach (qw(A B))'.

-- 
Jakub Narebski
Poland