From: Jeff King <peff@peff.net>
Date: Fri, 18 Feb 2011 10:41:51 GMT
Subject: Re: [PATCHv3 2/2] git-patch-id: do not trip over "no newline" markers
Message-ID: <20110218104151.GB7262@sigill.intra.peff.net>
In-Reply-To: <c0ee81b29d902e773dc851aaf86b99c9337079c9.1298023827.git.git@drmicha.warpmail.net>

On Fri, Feb 18, 2011 at 11:12:42AM +0100, Michael J Gruber wrote:

> Currently, patch-id trips over the diff extension for marking
> the absence of newline at EOF.
> 
> Fix it. (Ignore it, it's whitespace.)
> 
> This uses the same detection rationale as in buitlin/apply.c, which was
> introduced in
> 
> 433ef8a ([PATCH] Make git-apply understand incomplete lines in non-C locales, 2005-09-04)

Thanks, this looks good to me, with one style nit:

> +		else if (!memcmp(line, "\\ ", 2) && strlen(line)>=12)
> +			continue;

Whitespace around relational operators.

-Peff