From: Thomas Rast Date: Tue, 04 Jan 2011 19:12:25 GMT Subject: Re: [PATCH 08/31] rebase: align variable names Message-ID: <201101042012.25580.trast@student.ethz.ch> In-Reply-To: <1293528648-21873-9-git-send-email-martin.von.zweigbergk@gmail.com> Martin von Zweigbergk wrote: > Use the same names for variables that git-rebase--interactive.sh will > soon inherit from git-rebase.sh. AFAICS this is partly about spelling the variables in lowercase instead of all-caps. Wouldn't it be nicer to simply downcase *all* variables, so that the end result has a consistent coding style? > -# $UPSTREAM. They are not necessarily rewritten, but their children > +# $upstream. They are not necessarily rewritten, but their children [...] -- Thomas Rast trast@{inf,student}.ethz.ch