From: Johannes Sixt <j6t@kdbg.org>
Date: Fri, 31 Dec 2010 22:21:31 GMT
Subject: Re: [PATCH] Fix expected values of setup tests on Windows
Message-ID: <201012312321.31294.j6t@kdbg.org>
In-Reply-To: <20101231203019.GC5898@burratino>

On Freitag, 31. Dezember 2010, Jonathan Nieder wrote:
> Johannes Sixt wrote:
> > On Freitag, 31. Dezember 2010, Nguyen Thai Ngoc Duy wrote:
> >> in your patch does not. Does bash auto convert value in
> >> TRASH_DIRECTORY="$TE..." line?
> >
> > No. When this line is executed:
> >
> > TEST_DIRECTORY=$(pwd)
> >
> > $(pwd) still has its default behavior to return the POSIX style path. pwd
> > is redefined to pwd -W only later.
>
> Would it make sense to change it to
>
>  TEST_DIRECTORY=$PWD
>
> for clarity and robustness against code movement, then?

Yes, that would make sense.

-- Hannes