From: Thomas Rast <trast@student.ethz.ch>
Date: Sun, 26 Dec 2010 10:38:20 GMT
Subject: Re: Possible bug in "git rebase" (non-interactive) with regards to post-rewrite
Message-ID: <201012261138.21059.trast@student.ethz.ch>
In-Reply-To: <7vd3ot48ke.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> When "rebase --skip" is used to skip the last patch in the series, the
> code to wrap up the rewrite by copying the notes from old to new commits
> and also by running the post-rewrite hook was bypassed.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
[...]
> -if test "$this" -gt "$last"
> -then
> -	say Nothing to do.
> -	rm -fr "$dotest"
> -	exit
> -fi
> -
>  while test "$this" -le "$last"
>  do
>  	msgnum=`printf "%0${prec}d" $this`

Ack, thanks for patching this.

(I think it's saner anyway not to say "nothing to do" when the user
would expect "we're all done here"...)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch