From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Tue, 14 Dec 2010 22:31:45 GMT
Subject: Re: Re: [PATCH v3 2/8] mingw: work around irregular failures of unlink on windows
Message-ID: <20101214223145.GG4084@sandbox>
In-Reply-To: <AANLkTiksyVETuR8ftTojf=T2AhKGFtUAmqyj5u-00kW0@mail.gmail.com>

On Tue, Dec 14, 2010 at 11:14:13PM +0100, Erik Faye-Lund wrote:
> On Tue, Dec 14, 2010 at 11:11 PM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > +static inline int is_file_in_use_error(DWORD errcode)
> > +{
> > +       switch(GetLastError()) {
> 
> Why pass the error code in, just to ignore it? Shouldn't this switch
> on "errcode" instead?

Definitely. Thanks for spotting that.

Cheers Heiko