From: Jakub Narebski Date: Mon, 13 Dec 2010 00:48:55 GMT Subject: [RFC PATCH 1/2] gitweb: Go to DONE_REQUEST rather than DONE_GITWEB in die_error Message-ID: <20101213004644.9475.10102.stgit@localhost.localdomain> In-Reply-To: <20101213004259.9475.87376.stgit@localhost.localdomain> End the request after die_error finishes, rather than exiting gitweb instance (perhaps wrapped like in ModPerl::Registry or gitweb.psgi case). Signed-off-by: Jakub Narebski --- This patch was sent to git mailing list as a standalone RFC patch some time ago. This version doesn't change anything from previous version. I am keeping this patch (even though it is not strictly necessary), to have DONE_REQUEST label, which I think can be quite useful, even if die_error wouldn't be using it starting from the following commit. gitweb/gitweb.perl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index cfa511c..af45daa 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1147,6 +1147,7 @@ sub run { run_request(); + DONE_REQUEST: $post_dispatch_hook->() if $post_dispatch_hook; @@ -3669,7 +3670,7 @@ EOF print "\n"; git_footer_html(); - goto DONE_GITWEB + goto DONE_REQUEST unless ($opts{'-error_handler'}); }