From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 29 Nov 2010 17:16:29 GMT
Subject: Re: [PATCH] Make the tab width used for whitespace checks configurable
Message-ID: <20101129171629.GM8037@burratino>
In-Reply-To: <4CF366B1.8070400@viscovery.net>

Johannes Sixt wrote:

> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  I have a project that uses tab width 4, and which has a lot of whitespace
>  errors. This is very helpful to spot them when lines are changed that
>  are indented with 4 spaces.

Thanks.

For what it's worth, I like the idea and the patch looks good.
(I haven't checked for missed spots or read the test in detail,
though.)

> +                       if (0 < tabwidth && tabwidth < 0100)
> +                               rule &= ~WS_TAB_WIDTH_MASK, rule |= tabwidth;

Tab widths are recognized with atoi and out-of-range tab widths are
silently ignored.  Could we help the user spot typos somehow?