From: Konstantin Khomoutov <flatworm@users.sourceforge.net>
Date: Fri, 26 Nov 2010 23:28:25 GMT
Subject: Re: git-gui: commit message box doesn't respond to enter (only return)
Message-ID: <20101126232825.GE3264@localhost.localdomain>
In-Reply-To: <20101126203855.GA23258@burratino>

On Fri, Nov 26, 2010 at 02:38:55PM -0600, Jonathan Nieder wrote:

> David Laban wrote at http://bugs.debian.org/605041:
> 
> > Package: git-gui
> > Version: 1:1.7.2.3-2
> > Severity: minor
> >
> > If I click into the messagebox and hit enter, nothing happens.
> >
> > This is annoying because if I'm adding a new paragraph to my commit message, 
> > I will often do <click> <enter><enter> <start typing as normal>
> >
> > Don't ask me why I do this. I think enter is a lighter/easier to press
> > key than return, and is also on the path that my hand takes between the mouse
> > and the rest of the keyboard.
> >
> > I have also provisionally reported the following bug in tk, but I feel like
> > a bit of a n00b for doing so.
> >
> > http://sf.net/tracker/?func=detail&aid=3119824&group_id=12997&atid=112997
> 
> I can't reproduce this because this laptop does not have a distinct
> "numpad enter" key.
I've tested it on Debian Squeeze and added another comment on the
upstream bug report. In short: KP_Enter is not bound to any action in
Tk text widgets in X11, at least in 8.5.9.

But git-gui can be trivially patched to support this; that would be a
one-lineer. So if it is desired and will be accepted, I could prepare a
patch.