From: Jonathan Nieder Date: Fri, 26 Nov 2010 06:18:31 GMT Subject: Re: [RFC/PATCH 07/18] revert: put option information in an option struct Message-ID: <20101126061831.GE18751@burratino> In-Reply-To: <20101125212050.5188.8316.chriscool@tuxfamily.org> Christian Couder wrote: > This is needed because we want to reuse the parse_args() function > so that we can parse options saved in a TODO file. Why couldn't parse_args() write to the globals? I would be more convinced by an explanation like This helps attain greater sanity by being explicit about which functions depend on the parameters passed to cherry-pick.