From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 22 Nov 2010 17:20:57 GMT
Subject: Re: [PATCH] bash completion: add basic support for git-reflog
Message-ID: <20101122172057.GC2084@burratino>
In-Reply-To: <1290445749-4884-1-git-send-email-rctay89@gmail.com>

Tay Ray Chuan wrote:

> Gábor: hmm, it really seems that reflog is treated as plumbing - no completion
> is done for it.

Probably because it is listed as such in command-list.txt.  I guess
the user-facing command for reflog expiration is meant to be "git gc"?

> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1632,6 +1631,18 @@ _git_rebase ()
>  	__gitcomp "$(__git_refs)"
>  }
>  
> +_git_reflog ()
> +{
> +	local subcommands="show delete expire"

People really do seem to use these commands directly, so I'm all for
this.

I wish there were a way to easily point the end user from "git reflog
show" to "git log --walk-reflogs" (to make the list of other accepted
options more obvious) but I can't think of one.

Regards,
Jonathan