From: Thomas Rast <trast@student.ethz.ch>
Date: Mon, 22 Nov 2010 13:14:15 GMT
Subject: Re: [PATCH] rebase -i: remove undocumented '--verify' flag
Message-ID: <201011221414.15982.trast@student.ethz.ch>
In-Reply-To: <vpqoc9hsemy.fsf@bauges.imag.fr>

Matthieu Moy wrote:
> Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:
> 
> > Remove the undocumented and unused '--verify' flag from interactive
> > rebase.
> 
> I don't think this change is good. If a command has a --no-whatever
> flag, one expects the --whatever flag to exist too, even if it's a
> no-op.
[...]
> I think a better change would be to add a comment like
> 
> --verify)
> 	# no-op, exists because --no-verify exists too.

Shouldn't that be

  OK_TO_SKIP_PRE_REBASE=

instead, so that it undoes the effect of an earlier --no-verify?

> 	;;
-- 
Thomas Rast
trast@{inf,student}.ethz.ch