From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 18 Nov 2010 17:29:20 GMT
Subject: Re: [PATCH 2/2] A loose object is not corrupt if it cannot be read due to EMFILE
Message-ID: <20101118172920.GC16610@burratino>
In-Reply-To: <AANLkTikns0Rm5znC7FOa72qZXKpQzazKiYsPe-oDNMAk@mail.gmail.com>

Erik Faye-Lund wrote:

> I was wondering about the same thing, I don't think this approach is
> very easy to follow. But either way I think we should make sure
> opendir/closedir/readdir doesn't mess with errno.

Other platforms and are allowed to (and do) clobber errno in many
non-error situations, so the main effect would be to work around/hide
some git bugs.

For mingw-runtime, the balance might be different.  Making buggy,
non-portable application code easier to port does not sound like a bad
thing.

Just my two cents,
Jonathan