From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 14 Nov 2010 18:16:05 GMT
Subject: Re: [PATCH 003/160] gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1)
Message-ID: <20101114181605.GI26459@burratino>
In-Reply-To: <1289747245-23263-3-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> These are the modifications I made to envsubst.c as I turned it into
> sh-i18n--envsubst.c:
> 
>  * Added our git-compat-util.h header for xrealloc() and friends.
> 
>  * Removed inclusion of gettext-specific headers.
> 
>  * Removed most of main() and replaced it with my own. The modified
>    version only does option parsing for --variables. That's all it
>    needs.
> 
>  * Modified error() invocations to use our error() instead of
>    error(3).
> 
>  * Replaced the gettext XNMALLOC(n, size) macro with just
>    xmalloc(n). Since XNMALLOC() only allocated char's.
> 
>  * Removed the string_list_destroy function. It's redundant (also in
>    the upstream code).
> 
>  * Replaced the use of stdbool.h (a C99 header) by doing the following
>    replacements on the code:

Nit: can this be moved to a subdir?  Maybe po or i18n, or even
envsubst.  This could make it clearer that the code has an upstream
and should be updated when upstream is.

Jonathan