From: Jonathan Nieder Date: Thu, 11 Nov 2010 08:27:48 GMT Subject: Re: [PATCH v3 2/3] Add the 'fetch.recurseSubmodules' config setting Message-ID: <20101111082748.GA15525@burratino> In-Reply-To: <4CDBA5FD.20802@web.de> Jens Lehmann wrote: > Am 11.11.2010 01:02, schrieb Jonathan Nieder: >> This configuration item is read from .gitmodules, too, right? Would >> it be easy (or desirable) to make it not read from there? Either way, >> it would be nice to have a test so the behavior doesn't change without >> anyone noticing. > > "fetch.recurseSubmodules" is only read from .git/config. The one read > first from .gitmodules and then from .git/config is the per-submodule > setting "submodule..fetchRecurseSubmodules" added in 3/3. Sorry for the nonsense. Would it be easy (or desirable) to make _that_ one not be read from .gitmodules? > But > maybe I should add a test that "fetch.recurseSubmodules" also works > when set in the global config ... Yes, I agree that such a test would be good (though less important than a test for the behavior with no configuration set at all, say). A test to demonstrate that configuration aside from submodule.* is not read from .gitmodules would also be good imho, but I don't think it's a blocker for anything. :)