From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 11 Nov 2010 00:02:16 GMT
Subject: Re: [PATCH v3 2/3] Add the 'fetch.recurseSubmodules' config setting
Message-ID: <20101111000216.GA14189@burratino>
In-Reply-To: <4CDB30D6.5040302@web.de>

Jens Lehmann wrote:

> --- a/t/t5526-fetch-submodules.sh
> +++ b/t/t5526-fetch-submodules.sh
> @@ -106,4 +106,40 @@ test_expect_success "--dry-run propagates to submodules" '
>  	test_cmp expect.err actual.err
>  '
> 
> +test_expect_success "recurseSubmodules=true propagates into submodules" '
> +	add_upstream_commit &&
> +	(
> +		cd downstream &&
> +		git config fetch.recurseSubmodules true
> +		git fetch >../actual.out 2>../actual.err
> +	) &&
> +	test_cmp expect.out actual.out &&
> +	test_cmp expect.err actual.err
> +'

This configuration item is read from .gitmodules, too, right?  Would
it be easy (or desirable) to make it not read from there?  Either way,
it would be nice to have a test so the behavior doesn't change without
anyone noticing.