From: Jeff King <peff@peff.net>
Date: Mon, 08 Nov 2010 18:18:01 GMT
Subject: Re: [PATCH 3/7] add description parameter to OPT__QUIET
Message-ID: <20101108181801.GB30428@sigill.intra.peff.net>
In-Reply-To: <4CD83ABD.30804@lsrfire.ath.cx>

On Mon, Nov 08, 2010 at 07:00:29PM +0100, René Scharfe wrote:

> Allows better help text to be defined than "be quiet".  Also make use
> of the macro in a place that already had a different description.  No
> object code changes intended.

Maybe my "don't repeat yourself" spider sense is over-reacting, but of
12 callsites, 11 of them will continue to use "be quiet". Maybe instead
of:

> -#define OPT__QUIET(var)    OPT_BOOLEAN('q', "quiet",   (var), "be quiet")
> +#define OPT__QUIET(var, h)    OPT_BOOLEAN('q', "quiet",   (var), (h))

we could have:

  #define OPT__QUIET_H(var, h) OPT_BOOLEAN('q', "quiet", (var), (h))
  #define OPT__QUIET(var) OPT__QUIET_H(var, "be quiet")

which would limit your patch to changing a single callsite.

-Peff