From: Matthijs Kooijman <matthijs@stdin.nl>
Date: Mon, 08 Nov 2010 13:14:12 GMT
Subject: Re: [PATCH] gitk: improve dark background support
Message-ID: <20101108131412.GE22067@login.drsnuggles.stderr.nl>
In-Reply-To: <20101104003524.GI7835@spacedout.fries.net>

Hi David,

I've been using gitk with a gray-on-black color-scheme for a while now,
so I've given your patch a test drive. It seems to work as expected and
indeed makes gitk a bit more pleasant to use with a dark color scheme.

I've reviewed the code a bit and it looks ok as well (though I'm hardly
familiar with git internals, and not at all in this area).

I did encounter one minor issue, though: If you change the foreground
color, the current view is not updated until you restart or switch views
(or otherwise trigger a redraw, I guess). A quick look at the code shows
that the "setfg" function contains some code that updates all canvases
and all contexts in $fglist with the new fg color. I guess that
something similar should be done for these tag colors to get them
updated right away (though perhaps that should be a second patch)?

A final note: There are still some other problems with working with
grey-on-black color scheme. In case your interested in working on those,
I've listed them at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=568470

Gr.

Matthijs