From: Jonathan Nieder <jrnieder@gmail.com>
Date: Fri, 05 Nov 2010 21:41:59 GMT
Subject: Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patches
Message-ID: <20101105214159.GA4457@burratino>
In-Reply-To: <20101020004533.b64d446c.ospite@studenti.unina.it>

Hi Antonio,

Antonio Ospite wrote:
> Junio C Hamano <gitster@pobox.com> wrote:

>> You are breaking the && chain here.
>
> Some other tests do that as well, the last line is a command by
> itself not and-chained with the git-send-email invocation. I guess the
> logic behind this is that the test succeeds if the _last_ command
> succeeds. If this is wrong then some other tests are affected too.

Yes, breaking the && chain is never a good thing.

See:

 - t/README: "Chain your test assertions"
 - v1.5.4~20 (t9001: add missing && operators, 2008-01-21)
 - git log --grep=&&

Hope that helps,
Jonathan